Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@vx/threshold needs to generate unique clippath ids #341

Closed
techniq opened this issue Aug 27, 2018 · 3 comments · Fixed by #342
Closed

@vx/threshold needs to generate unique clippath ids #341

techniq opened this issue Aug 27, 2018 · 3 comments · Fixed by #342

Comments

@techniq
Copy link
Collaborator

techniq commented Aug 27, 2018

Currently Threshold is using the same threshold-clip-below and threshold-clip-above ClipPath ids which causes an issue when using more than 1 Threshold chart on a page:

image

We need to generate unique ids for each of these per instance.

@williaster
Copy link
Collaborator

irrespective of the issue, chart 2 looks pretty cool like that :) need to play with clip paths more.

@techniq
Copy link
Collaborator Author

techniq commented Aug 27, 2018

@williaster It did actually :). This made it easier to see (chart 1 is showing accumulated values over a month), when they were daily it was more painful to track down the cause...

image

@hshoff
Copy link
Member

hshoff commented Aug 27, 2018

@techniq just published @vx/threshold@0.0.174 with the id prop fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants