Unpinning Airbyte CDK to get freebie upgrades before 1.0 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natikgadzhi - Rejecting this and replacing with a bump to latest version: Happy to take a dependabot-like auto-update if we have that option open up. However, I don't think we can leave this unpinned until CDK reaches a stable 1.0 status. As specified in semver (https://semver.org/):
Dependabot updates (in contrast) would go through a PR/CI for each update, which mitigates the volatility concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay hear me out. Good news is that we might get free dependabot-triggered updates for the CDK, and get latest bugfixes. That will come handy as we wire up declarative sources!
Bad news is that we might break things, but we will unpin the CDK in all sources, and we have
Poetry.lockto protect us from yolo-bug-problems.