Fix: Default to docker-based destination executors

[aaronsteers]

Summary by CodeRabbit

• New Features
  • Enhanced flexibility in handling the docker_image parameter for connector and destination functions, now accepting None as a valid input.
  • Introduced improved default behavior for the docker_image parameter when both pip_url and local_executable are not provided, favoring Docker-based execution.

[coderabbitai]

Walkthrough

Walkthrough

The recent changes enhance the flexibility of the get_connector_executor and get_destination functions by allowing their docker_image parameters to accept None as a valid input. Additionally, the get_destination function introduces logic to default to Docker-based execution when no installation method is specified, improving the robustness of the functions and ensuring a valid execution method is always chosen.

Changes

Files	Change Summary
airbyte/_executors/util.py	Updated docker_image parameter in get_connector_executor to accept None.
airbyte/destinations/util.py	Updated docker_image parameter in get_destination to accept None and added default logic for Docker execution.

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 67502d5 and 80d644d.

Files selected for processing (2)

• airbyte/_executors/util.py (1 hunks)
• airbyte/destinations/util.py (2 hunks)

Additional comments not posted (3)

airbyte/destinations/util.py (2)

26-26: LGTM! Type annotation change approved.

The type annotation change for docker_image from str | bool to str | bool | None enhances flexibility.

---

53-56: LGTM! New logic for defaulting to Docker-based execution approved.

The new logic ensures robustness by defaulting to Docker-based execution when pip_url and local_executable are not provided.

airbyte/_executors/util.py (1)

34-34: LGTM! Type annotation change approved.

The type annotation change for docker_image from bool | str to bool | str | None enhances flexibility and aligns with the changes made in airbyte/destinations/util.py.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.