Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Spammy logging from grpcio (temporarily force-downgrade grpcio) #334

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Aug 9, 2024

A few versions ago, PyAirbyte started emitting excessive log messages which could be confusing to users:

WARNING: All log messages before absl::InitializeLog() is called are written to STDERR
I0000 00:00:1723226680.150640 10254765 config.cc:230] gRPC experiments enabled: call_status_override_on_cancellation, event_engine_dns, event_engine_listener, http2_stats_fix, monitoring_experiment, pick_first_new, trace_record_callops, work_serializer_clears_time_cache
I0000 00:00:1723226680.159974 10254765 check_gcp_environment_no_op.cc:29] ALTS: Platforms other than Linux and Windows are not supported
I0000 00:00:1723226680.655466 10254765 work_stealing_thread_pool.cc:320] WorkStealingThreadPoolImpl::PrepareFork
I0000 00:00:1723226680.699688 10254765 work_stealing_thread_pool.cc:320] WorkStealingThreadPoolImpl::PrepareFork
Connection check succeeded for `source-salesforce`.
I0000 00:00:1723226682.825618 10254765 work_stealing_thread_pool.cc:320] WorkStealingThreadPoolImpl::PrepareFork
I0000 00:00:1723226685.168750 10254765 check_gcp_environment_no_op.cc:29] ALTS: Platforms other than Linux and Windows are not supported
I0000 00:00:1723226685.734473 10254765 check_gcp_environment_no_op.cc:29] ALTS: Platforms other than Linux and Windows are not supported
I0000 00:00:1723226687.078290 10254765 check_gcp_environment_no_op.cc:29] ALTS: Platforms other than Linux and Windows are not supported

I0000 00:00:1723226687.499203 10254765 check_gcp_environment_no_op.cc:29] ALTS: Platforms other than Linux and Windows are not supported
I0000 00:00:1723226688.954090 10254765 work_stealing_thread_pool.cc:320] WorkStealingThreadPoolImpl::PrepareFork
The following streams are currently using incremental sync:

This is tracked here:

This PR temporarily declares and pins grpcio to <= 1.65.0 until the issue settles. (Previously, it was only a transitive dependency.)

Summary by CodeRabbit

  • Chores
    • Added a new dependency for the grpcio package to ensure compatibility and stability within the project.

Copy link

coderabbitai bot commented Aug 9, 2024

Walkthrough

Walkthrough

The recent changes involve updating the pyproject.toml file to include a new dependency on the grpcio package, specifically limited to version <=1.65.0. This addition highlights a requirement for compatibility with other components or to resolve known issues with newer versions, without affecting existing dependencies.

Changes

File Change Summary
pyproject.toml Added dependency: grpcio = "<=1.65.0"

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4c293d8 and fe112cf.

Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
Files selected for processing (1)
  • pyproject.toml (1 hunks)
Additional comments not posted (1)
pyproject.toml (1)

50-50: Verify compatibility with other dependencies.

The addition of grpcio = "<=1.65.0" is intended to address logging issues. Ensure that this version constraint does not introduce compatibility issues with other dependencies in the project.

Verification successful

No immediate compatibility issues found with grpcio version constraint.

The addition of grpcio = "<=1.65.0" does not appear to conflict with other dependencies in the pyproject.toml or poetry.lock files. The lock file entries for grpcio include constraints that are compatible with this version limit. However, ensure thorough testing to confirm the absence of runtime issues.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify compatibility of grpcio version constraint with other dependencies.

# Test: Check for any dependency conflicts. Expect: No conflicts.
poetry check || echo "Check for dependency conflicts."

Length of output: 161


Script:

#!/bin/bash
# Search for dependencies in pyproject.toml that might conflict with grpcio <= 1.65.0
rg '^\s*[a-zA-Z0-9_-]+\s*=' pyproject.toml

# Search the codebase for any mentions of grpcio to identify potential version conflicts
rg 'grpcio'

Length of output: 14411


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@aaronsteers aaronsteers enabled auto-merge (squash) August 9, 2024 18:15
@aaronsteers aaronsteers changed the title fix: spamming logging from grpcio (force-downgrade grpcio) Fix: Spammy logging from grpcio (force-downgrade grpcio) Aug 9, 2024
@aaronsteers aaronsteers changed the title Fix: Spammy logging from grpcio (force-downgrade grpcio) Fix: Spammy logging from grpcio (temporarily force-downgrade grpcio) Aug 9, 2024
@aaronsteers aaronsteers merged commit 383d89c into main Aug 9, 2024
16 of 19 checks passed
@aaronsteers aaronsteers deleted the aj/fix/spamming-logging-from-grpcio branch August 9, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant