Feat: Add BigQuery cache support; Fix: IPython rendering bug when using a TTY #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bindipankhudi
commented
Feb 23, 2024
bindipankhudi
commented
Feb 23, 2024
aaronsteers
changed the title
aaronsteers
changed the title
- use 'supports_merge_insert=True' ('emulated' merge insert alternative not supported)
- perf tuning on _ensure_schema_exists() and _table_exists()
- use google-cloud-bigquery library for inserting jsonl to table
aaronsteers
approved these changes
Feb 24, 2024
aaronsteers
changed the title
|
@bindipankhudi - This one is ready to merge. 🚀 Thanks for working out all the implementation details and type conversion issues. I noted my changes in a review above. I'll probably merge this in today or tomorrow, since it contains some other bug fixes and optimizations which will be helpful broadly. |
|
Thank you so much for working out all the issues here!! 🙏I really
appreciate it!! I was out for the evening so just saw this. I read all your
comments which make sense to me. I will look at the PR in detail tomm
morning, but feel free to merge anytime since there are so many other
changes in here.
…On Fri, Feb 23, 2024 at 8:25 PM aaronsteers ***@***.***> wrote:
@bindipankhudi <https://github.com/bindipankhudi> - This one is ready to
merge. 🚀
Thanks for working out all the implementation details and type conversion
issues. I noted my changes in a review above.
I'll probably merge this in today or tomorrow, since it contains some
other bug fixes and optimizations which will be helpful broadly.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BF2EJSWJR767X6N2YYZGWHLYVFTT3AVCNFSM6AAAAABDXKHBPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRSGI2DQNBQGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
bindipankhudi
commented
Feb 24, 2024
bindipankhudi
commented
Feb 24, 2024
aaronsteers
changed the title
aaronsteers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following:
For append and replace cases, data gets written to final table and temp table also gets removed. Writing to _airbytelib_state fails due to some datetime/timestamp mismatch.