Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add .gitignore rules for secrets dirs #96

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

aaronsteers
Copy link
Contributor

If we run connectors_ci, it will create these directories. This PR ensures we keep git history safe from accidentally committed secrets in secrets or .secrets dirs.

@aaronsteers aaronsteers changed the title Chore: git-ignore secrets dirs Chore: Add .gitignore rules for secrets dirs Mar 5, 2024
@aaronsteers
Copy link
Contributor Author

@bindipankhudi - FYI. I'm going to go ahead and merge this to prevent secrets usage while I begin working with the ci_credentials tool.

No action needed, but wanted to tag you for visibility.

@aaronsteers aaronsteers merged commit 11a78e2 into main Mar 5, 2024
9 of 10 checks passed
@aaronsteers aaronsteers deleted the aj/ignore-secrets-dirs branch March 5, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant