Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resolve Python 3.9 compatibility issues, expand CI test matrix #98

Merged
merged 8 commits into from
Mar 5, 2024

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Mar 5, 2024

This adds Python 3.9 and 3.11 back into the test matrix.

Findings:

  • Python 3.11 worked without any issue.
  • Python 3.9 was failing because Pydantic wants to parse/evaluate type hints for classes derived from pydantic.BaseModel.
    • I disabled the lint rule that dissallowed the legacy syntaxes Union[x | y] and Optional[x].
    • In any subclasses of BaseModel, I reverted to legacy-style syntax declarations, to appease the Pydantic eval statements.

@aaronsteers aaronsteers changed the title [Draft]: Add back testing for Python 3.9 and 3.11 Fix: Resolve Python 3.9 compatibility issues and add CI test matrix Mar 5, 2024
@aaronsteers aaronsteers changed the title Fix: Resolve Python 3.9 compatibility issues and add CI test matrix Fix: Resolve Python 3.9 compatibility issues, expand CI test matrix Mar 5, 2024
@aaronsteers aaronsteers linked an issue Mar 5, 2024 that may be closed by this pull request
@aaronsteers aaronsteers merged commit 9e5cc3e into main Mar 5, 2024
11 checks passed
@aaronsteers aaronsteers deleted the aj/support-py39 branch March 5, 2024 06:08
@aaronsteers
Copy link
Contributor Author

aaronsteers commented Mar 5, 2024

@bindipankhudi - Another FYI above; this resolves the Py3.9 compatibility issues. No action needed. Going forward, we'll get CI failures if Python 3.9 or Python 3.11 tests fail (in addition to Python 3.10).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Python 3.9 is declared as supported but not passing tests.
1 participant