fix(jsonSchemas): raise error when items property not provided (#14018)

Author: terussell85

airbyte-commons/src/main/java/io/airbyte/commons/json/JsonSchemas.java

@@ -190,8 +190,13 @@ private static void traverseJsonSchemaInternal(final JsonNode jsonSchemaNode,
         // case BOOLEAN_TYPE, NUMBER_TYPE, STRING_TYPE, NULL_TYPE -> do nothing after consumer.accept above.
         case ARRAY_TYPE -> {
           final List<FieldNameOrList> newPath = MoreLists.add(path, FieldNameOrList.list());
-          // hit every node.
-          traverseJsonSchemaInternal(jsonSchemaNode.get(JSON_SCHEMA_ITEMS_KEY), newPath, consumer);
+          if (jsonSchemaNode.has(JSON_SCHEMA_ITEMS_KEY)) {
+            // hit every node.
+            traverseJsonSchemaInternal(jsonSchemaNode.get(JSON_SCHEMA_ITEMS_KEY), newPath, consumer);
+          } else {
+            throw new IllegalArgumentException(
+                "malformed JsonSchema array type, must have items field in " + jsonSchemaNode);
+          }
         }
         case OBJECT_TYPE -> {
           final Optional<String> comboKeyWordOptional = getKeywordIfComposite(jsonSchemaNode);

airbyte-commons/src/test/java/io/airbyte/commons/json/JsonSchemasTest.java

@@ -5,6 +5,7 @@
 package io.airbyte.commons.json;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 import static org.mockito.Mockito.mock;
 
 import com.fasterxml.jackson.databind.JsonNode;
@@ -132,4 +133,13 @@ void testTraverseMultiTypeComposite() throws IOException {
     inOrder.verifyNoMoreInteractions();
   }
 
+  @SuppressWarnings("unchecked")
+  @Test
+  void testTraverseArrayTypeWithNoItemsThrowsException() throws IOException {
+    final JsonNode jsonWithAllTypes = Jsons.deserialize(MoreResources.readResource("json_schemas/json_with_array_type_fields_no_items.json"));
+    final BiConsumer<JsonNode, List<FieldNameOrList>> mock = mock(BiConsumer.class);
+
+    assertThrows(IllegalArgumentException.class, () -> JsonSchemas.traverseJsonSchema(jsonWithAllTypes, mock));
+  }
+
 }

airbyte-commons/src/test/resources/json_schemas/json_with_array_type_fields_no_items.json

@@ -0,0 +1,9 @@
+{
+  "type": ["object", "array"],
+  "properties": {
+    "company": {
+      "type": "string",
+      "description": "company name"
+    }
+  }
+}