Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harvest source connector doesn't sync parent_id for parent/child data (Ex: Invoices/InvoiceMessages) #10350

Closed
Tracked by #14055
jadetr opened this issue Feb 15, 2022 · 1 comment · Fixed by #15221
Closed
Tracked by #14055

Comments

@jadetr
Copy link
Contributor

jadetr commented Feb 15, 2022

Environment

  • Airbyte version: 0.35.4-alpha
  • OS Version / Instance: Ubuntu 18.04
  • Deployment: Docker
  • Source Connector and version: [airbyte/source-harvest] V 0.1.8
  • Severity: Medium
  • Step where error happened: Sync job

Current Behavior

The way the Harvest API is built is by calling a url with the invoice ID to get the list of associated messages.
I don't see the parent_id as being saved in the child row so there is no way to connected the message to an invoice.

Expected Behavior

parent_id should be saved in all parent-child relationship for this connector

This is expected for invoice and estimate.

In source code I see something like that. We see the url path that takes a parent_id.
the parent_id is used in the url BUT never saved into the child's row.

class InvoiceMessages(HarvestSubStream, IncrementalHarvestStream):
"""
Docs: https://help.getharvest.com/api-v2/invoices-api/invoices/invoice-messages/
"""
parent_stream = Invoices
path_template = "invoices/{parent_id}/messages" (edited)

Logs

LOG

replace this with
your long log
output here

Steps to Reproduce

Are you willing to submit a PR?

Remove this with your answer.

@jadetr jadetr added needs-triage type/bug Something isn't working labels Feb 15, 2022
@bleonard bleonard added autoteam team/tse Technical Support Engineers labels Apr 26, 2022
@jadetr
Copy link
Contributor Author

jadetr commented May 13, 2022

Please let me know if I need to provide more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants