-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify users of auto-disabled connections #10929
Comments
Got some feedback from Natalie:
|
we do not currently have a way to send emails to users as far as i'm aware. @davinchia am I wrong on this? do we have sendgrid set up somewhere? |
@terencecho if you take a look at Sending emails from OSS is hard because it requires having the user set up a mail server or using ours (which is very dangerous). We should skip supporting it in OSS for now. Based on Davin's response about our email setup, you could set up an email |
@nataliekwong should probably be involved in that conversation |
We can use customer.io as a way to send emails to Cloud users, as all Cloud users are already in customer.io today. I agree on not sending emails to OSS users. Here is what I sent Terence, in a follow-up message:
For the initial implementation, I suggest we send this as a transactional email as it's a product-triggered notification and should not be able to be opted out from. We could allow for opt-out of connector turnoff notifications in the future (as you suggested, a toggle in the UI), but to start it would be mandatory. Outside of this particular issue, I have gotten a few requests for an email notification feature as users don't want to go through the hurdle of setting up a webhook. If we were to develop that feature, we could continue to use customer.io to send those emails, or move all product-triggered emails to Sendgrid. Ideally we consolidate so that we have clear delineations on what kinds of emails are being sent and from where. |
We do use Sendgrid today to send the new user invite and workspace invite emails. See https://github.com/airbytehq/airbyte-cloud/blob/master/cloud-server/src/main/java/io/airbyte/cloud/server/email/Sendgrid.java. Log in is in lastpass. I don't have an opinion on customer.io vs Sendgrid. |
I don't have enough context to have an opinion between customer.io vs sendgrid. But I think it makes sense to create an email implementation of |
Let's use customer.io then. Better to consolidate towards a single tool. Sounds like we have a clear owner of customer.io and buy in from GTM. Sendgrid is a bit of an orphan in our stack right now. |
Going to leave this issue open until the feature flag is turned on in cloud |
This has been deployed to production as of 5/2/22. |
Tell us about the problem you're trying to solve
With the additional feature of adding an option to auto-disable failing connections from this issue, we want to clearly define how the notification of a connection being auto-disabled should be surfaced.
For example, do we want an email or a pop-up? Do we want to confirm that the user has acknowledged this automated disablement of a connection? etc.
The text was updated successfully, but these errors were encountered: