-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mixpanel Export.process_response() Fails in case of JSON text properties cointaining underlying line breaks #11018
Comments
💡 Investigating further, I could narrow down the issue to being an issue with how Export API Response is parsed using It seems that some lines are "cut" randomly in between. I identified that in case line some text properties included a line break as follow for example, Here the example, see the
|
💡 Using |
Hi @guillaume-chech :) Thank you very much for going into the debugging yourself. If you found the bug you definitely have the skills to fix it 👍 . The procedure is quite simple:
|
Hi 👋 @alafanechere Thanks for the motivational response. Here it is : I hope it follows what you expected , I could not run the acceptance test unfortunately and I'm not sure how to perform every item of the PR check list. Happy review ! |
Closing this as it looks like PR was merged. |
Environment
Current Behavior
When retrieving
export
objects from Mixpanel, if the response from Mixpanel contains malformed Json the whole sync job crashes. This is a problem because Mixpanel allow only to retrieve data for a full day granularity. So it's impossible to skip a fraction (1 minute or 2 of data where the data is faulty) the only issue is to skip a whole day, which is not really possible in terme of data loss.Expected Behavior
We would expect the connector to first retry, and offer the possibility to ignore malformed events.
Logs
Steps to Reproduce
Unsure how to reproduce this as I could not find in the logs which events are faulty or not
Are you willing to submit a PR?
No, I'm not capable of such a thing .
Related issue : #11008
The text was updated successfully, but these errors were encountered: