-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override REACT_APP_API_URL #1102
Comments
Thanks @guillaumelachaud. Indeed, I think we should implement it this way. @cgardens that will likely be necessary to support the URL as an env variable once we set up airbyte for k8s |
btw @guillaumelachaud if you're creating k8s manifests, any chance you could share them? We want to release some for mid-Dec |
I definitely can share them but ultimately, I didn't manage to completely deploy Airbyte over K8s. Here's a quick recap of what's not working yet (though it's not the topic of the current ticket):
Also, the Helm charts I have written are GCP specific as it uses Cloud IAP to add an authentication mechanism in front of the services. |
Thanks! Added your comment to the k8s issue |
Tell us about the problem you're trying to solve
Trying to deploy Airbyte on GKE behind cloud IAP to secure the deployment. Traffic between web-app and API must go through port 443 in order for this to work. Current implementation looks if REACT_APP_API_URL is set or defaults to port 8001. As REACT_APP_API_URL is set at build time, it's not convenient to change it.
Describe the solution you’d like
Make it easier to override this env var at runtime, just as TRACKING_STRATEGY
Describe the alternative you’ve considered or used
Alternative is for me to build my own custom image of airbyte/webapp which I don't have the time to maintain
The text was updated successfully, but these errors were encountered: