Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add better support for incremental in standard source tests #1217

Closed
cgardens opened this issue Dec 5, 2020 · 1 comment
Closed

Add better support for incremental in standard source tests #1217

cgardens opened this issue Dec 5, 2020 · 1 comment
Labels
incremental type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

cgardens commented Dec 5, 2020

Tell us about the problem you're trying to solve

  • The standard source tests make some goofy assumptions to figure how to mutate a given catalog to be used for testing incremental. The assumptions are super brittle. They were good for getting the first 2 integrations out the door, but it's time to make it sturdier.

Describe the solution you’d like

We need to add support for incremental into the interface so there is less implicit stuff going on.

┆Issue is synchronized with this Asana task by Unito

@cgardens
Copy link
Contributor Author

cgardens commented Dec 7, 2020

@sherifnada and I discussed offline. Agreed that there's no work that needs to be done now. In the future we'd like to test for individual records in the standard tests. (or do it in specific integration tests). Either way doesn't need to be done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incremental type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants