-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database sources should not log to stderr
when things are OK
#13583
Comments
stderr
when things are working OK
Yes, this is probably not intended and a bug. |
stderr
when things are working OKstderr
when things are OK
Performed some investigation. |
Awesome! Are there other DB connectors we should publish to get this fix in? |
destinations gcs and s3 didn't publish successfully in #14801 and destination-databricks maybe also needs to be published; reopening. @DoNotPanicUA it might make sense to just try and get those published in a followup PR, what do you think? (I merged the PR early to unblock some exciting postgres publishes, but otherwise have no context on this issue :P ) |
S3, GCS, and Databricks successfully published with the fix. |
Try
docker run airbyte/source-mysql spec 1>stdour.log 2>stderr.log
and you'll see some warnings emitted onstderr
:stdout.log
stderr.log
The command worked, and the
stderr
messages are more-or-less meaningless to an end-user. I propose that messages which are not fatal (e.g. causing a crash/excaption/exit) are not emitted onstderr
.This was also observed in a
airbyte/source-postgres
as well. There are likley other connectors that behave the same way.The text was updated successfully, but these errors were encountered: