Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source Sentry: support oauth #14293

Closed
igrankova opened this issue Jun 30, 2022 · 5 comments
Closed

🎉 Source Sentry: support oauth #14293

igrankova opened this issue Jun 30, 2022 · 5 comments

Comments

@igrankova
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret
  2. Oauth properties are annotated properly. See this PR for an example
@sherifnada
Copy link
Contributor

Sentry does not support oauth as far as I can tell: https://docs.sentry.io/product/integrations/integration-platform/#internal-integrations so I don't think we need this ticket

cc @YowanR

@igrankova
Copy link
Contributor Author

igrankova commented Aug 12, 2022

@sherifnada
Copy link
Contributor

ah you are right. ignore me!

@roman-yermilov-gl roman-yermilov-gl self-assigned this Aug 22, 2022
@bazarnov bazarnov changed the title Source Sentry: support oauth 🎉 Source Sentry: support oauth Aug 23, 2022
@roman-yermilov-gl
Copy link
Contributor

roman-yermilov-gl commented Sep 5, 2022

Sentry does not have OAuth flow. It only has OAuth for public integrations which require those apps to implement webhook which will be called manually from Sentry Integration page. This is not that OAuth that we are currently support in Airbyte.
@ycherniaiev asked Sentry support for more information, so I can do nothing until we receive feedback from them.

@bazarnov bazarnov closed this as completed Sep 7, 2022
@YowanR
Copy link
Contributor

YowanR commented Sep 15, 2022

@sherifnada Could you take a look at this? Would we ever consider doing the work to support OAuth for Sentry? If so we can create an issue to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants