Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and release per-stream state handling in Postgres Source #14457

Closed
3 tasks done
grishick opened this issue Jul 6, 2022 · 4 comments
Closed
3 tasks done

Test and release per-stream state handling in Postgres Source #14457

grishick opened this issue Jul 6, 2022 · 4 comments
Assignees

Comments

@grishick
Copy link
Contributor

grishick commented Jul 6, 2022

Once platform is ready with per-stream state, we need to manually test

  • adding/removing tables to Postgres Source
  • connections created with older connector version of Postgres Source (current version in Cloud)
  • file any issues that we find

Context:

@grishick
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with ZenHub @edgao @ryankfu @subodh1810

@ryankfu ryankfu assigned ryankfu and unassigned ryankfu Jul 18, 2022
@ryankfu
Copy link
Contributor

ryankfu commented Jul 21, 2022

UPDATE: this ticket is mostly taken care of by the OSS platform team with acceptance tests from Lake and Benoit. I do need to provide an update to them on the create a connection with an older version of the Postgres source but I believe their tests currently cover that (not fully verified)

I'm going to instead shift this ticket to address the documentation of the logic that was discovered as a result of spectating Benoit and Lake set up a per-stream non-CDC sync locally. I will update the ticket with a living google doc and tag the databases and oss-platform team once it's ready for review. Furthermore, I'm adding in a diagram of how our syncs work prior to per-stream changes and after per-stream through Whimsical

@ryankfu
Copy link
Contributor

ryankfu commented Jul 25, 2022

OSS platform team merged the per-stream changes today https://github.com/airbytehq/airbyte-cloud/pull/2151 which enables per-stream changes onto Airbyte Cloud that is useful for testing

Additionally, will be documenting any issues with setup and testing within Postgres Source GA doc. Due note that the document is not visible to non-Airbyters while the team continues to work out any refinements in the setup and information sharing process

Platform OSS filed issues related to per-stream state handling:

  • Validate only on incremental #14966 - this addresses the issue where previously the validation logic also applied to full-sync streams when that particular mode does not create a state within per-stream

@ryankfu
Copy link
Contributor

ryankfu commented Aug 9, 2022

Document covering the per-stream changes here with overview of the complications, what is per-stream and protocol changes necessary to get per-stream operational

@ryankfu ryankfu closed this as completed Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants