Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-postgres: make withConnectionTimeoutMs configurable #14498

Closed
alafanechere opened this issue Jul 7, 2022 · 5 comments
Closed

source-postgres: make withConnectionTimeoutMs configurable #14498

alafanechere opened this issue Jul 7, 2022 · 5 comments
Assignees
Labels
area/connectors Connector related issues connectors/source/postgres type/enhancement New feature or request

Comments

@alafanechere
Copy link
Contributor

Tell us about the problem you're trying to solve

The current connection to JDBC database is created with a hardcoded value for connectionTimeoutMsof 60000.
This can cause problems according to specific database setup and context.

Describe the solution you’d like

We could make the JDBC params override this value.
The withConnectionTimeoutMs builder method that changes the timeout is not used by any connector.

Additional context

Related forum conversation

@grishick
Copy link
Contributor

grishick commented Jul 8, 2022

Can users set a timeout via optional JDBC parameters?

@anton-epsagon
Copy link

@grishick no, those seem to be ignored.
I'm currently trying to change the timeout value in airbyte-db/db-lib/src/main/java/io/airbyte/db/factory/DataSourceFactory.java locally to see if that helps

@grishick
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @edgao @ryankfu @subodh1810 @tuliren

@grishick
Copy link
Contributor

grishick commented Jul 20, 2022

Notes on testing:

  • unit test should verify that the timeout is passed onto Hikari JDBC driver
  • we should not be adding an integration test for this, because we are not testing the JDBC driver itself

@ryankfu ryankfu self-assigned this Jul 20, 2022
@ryankfu
Copy link
Contributor

ryankfu commented Aug 4, 2022

Issue has been resolved in this PR #15226

@ryankfu ryankfu closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues connectors/source/postgres type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants