Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only validate that incremental streams have state before migrating connection to per-stream #14962

Closed
evantahler opened this issue Jul 22, 2022 · 2 comments · Fixed by #14966
Closed

Comments

@evantahler
Copy link
Contributor

evantahler commented Jul 22, 2022

We have a check (#14599 / #14519) when migrating syncs to per-stream state that ensures that every enabled stream has state before migrating. However, this check should only happen for incremental streams

@lmossman
Copy link
Contributor

lmossman commented Jul 22, 2022

I don't think this ticket is necessary. The validation only checks if the state that was produced at the end of the sync has states for all streams in the catalog, before it writes that state to the database. So this shouldn't matter if a sync had ran before or not

@evantahler evantahler changed the title Do not prevent migration to per-stream state for syncs that have never run Only validate that incremental streams have state before migrating connection from legacy to per-stream state Jul 22, 2022
@evantahler
Copy link
Contributor Author

Title & description updated

@evantahler evantahler changed the title Only validate that incremental streams have state before migrating connection from legacy to per-stream state Only validate that incremental streams have state before migrating connection to per-stream Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants