Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply default sync mode logic to new streams after refresh source schema #16013

Closed
timroes opened this issue Aug 26, 2022 · 2 comments · Fixed by #18451
Closed

Apply default sync mode logic to new streams after refresh source schema #16013

timroes opened this issue Aug 26, 2022 · 2 comments · Fixed by #18451
Assignees
Labels
area/frontend Related to the Airbyte webapp team/platform-move type/bug Something isn't working

Comments

@timroes
Copy link
Collaborator

timroes commented Aug 26, 2022

We currently handle the default sync mode logic in the FE. We though only apply this when the connection is not in edit mode, but created. That means if a user "refreshed source schema" of a connection and new streams are detected those new streams are not getting the default sync mode logic applied, but stay with whatever the config of the backend told us is default (which is not the correct one by the logic we try to go for).

We should make sure that the default sync mode logic in https://github.com/airbytehq/airbyte/blob/master/airbyte-webapp/src/views/Connection/ConnectionForm/calculateInitialCatalog.ts will apply as well for streams that are new after a "Refresh source schema".

@timroes timroes added type/bug Something isn't working area/frontend Related to the Airbyte webapp ui/connection and removed team/triage labels Aug 26, 2022
@octavia-squidington-iii
Copy link
Collaborator

cc @airbytehq/frontend

@teallarson
Copy link
Contributor

was closed by #18451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp team/platform-move type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants