Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data types protocol proposal - second async + synchronous review #16679

Closed
1 of 3 tasks
edgao opened this issue Sep 13, 2022 · 4 comments
Closed
1 of 3 tasks

Data types protocol proposal - second async + synchronous review #16679

edgao opened this issue Sep 13, 2022 · 4 comments
Assignees
@edgao
Labels
team/destinations Destinations team's backlog

Comments

@edgao
Copy link
Contributor

edgao commented Sep 13, 2022 •
edited
Loading

Finish #17486:

  • Receive approvals
  • Update documentation
  • Finalize regexes/etc
@grishick grishick added the team/destinations Destinations team's backlog label Sep 27, 2022
@edgao edgao self-assigned this Oct 5, 2022
@edgao
Copy link
Contributor Author

edgao commented Oct 5, 2022

protocol PR - #17486

@edgao
Copy link
Contributor Author

edgao commented Oct 12, 2022

no further comments. I want to polish some of the regexes etc and update docs, then this is good to close + unblock all the implementation tickets

@grishick
Copy link
Contributor

grishick commented Nov 4, 2022

ping @edgao what's left here?

@edgao
Copy link
Contributor Author

edgao commented Nov 4, 2022

gah, I will never remember to close issues >.> thanks for the ping

@edgao edgao closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@edgao edgao

Labels
team/destinations Destinations team's backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grishick @edgao