Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create common sortable column button #17062

Closed
edmundito opened this issue Sep 22, 2022 · 0 comments · Fixed by #17798
Closed

Create common sortable column button #17062

edmundito opened this issue Sep 22, 2022 · 0 comments · Fixed by #17798
Assignees
Labels

Comments

@edmundito
Copy link
Contributor

Follow up to #16604

ConnectionTable, ImplementationTable, UsagePerConnectionTable.tsx, use the same pattern for the sort button. Example:

<button className={styles.tableHeaderButton} onClick={() => onSortClick("name")}>
  <FormattedMessage id="tables.name" />
  <SortIcon wasActive={sortBy === "name"} lowToLarge={sortOrder === SortOrderEnum.ASC} />
</button>

The goal is to create a new component that can be applied to the files above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants