You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apparently it's possible for a destination to only write data into its default namespace and still pass our DATs. We should add a test case that verifies it can write to a non-default namespace. I.e. if the catalog looks like:
Let's look into why it wasn't failing prior to #17054, and fix that. (A likely avenue of investigation: should this sourcenamespace be randomized per test run?)
In order to run BigQueryGcsDestinationAcceptanceTest locally, you'll need to manually create airbyte-integrations/connectors/destination-bigquery/secrets/credentials.json, using the contents here.
And you can explore our integration test BigQuery instance here.
The text was updated successfully, but these errors were encountered:
Continued Investigating this with @edgao today and discovered that the integration testing for the big query destination does not cover the standard inserts mode and only covers staging (GCS). The Bug from the original oncall issue only affected the standard inserts mode, thus the test is passing because we are not executing the code which contained the bug (which has since been resolved )
Disregard the comment above. I identified an issue with my airbyte setup such that the docker containers were not being rebuilt despite code changes. With rebuilt docker containers this works as @edgao suspects - by randomizing the dataset id the test will fail. This is implemented in #20775
from https://docs.google.com/document/d/15xLW97ZqPnttLluP80ZCqXxCHHzB-vn8bhBBpUmjGMI/edit#
Apparently it's possible for a destination to only write data into its default namespace and still pass our DATs. We should add a test case that verifies it can write to a non-default namespace. I.e. if the catalog looks like:
Then the DATs should verify that after a sync, a table called
some_non_default_namespace.whatever
was created.Details
It looks like this test case already exists -
airbyte/airbyte-integrations/bases/standard-destination-test/src/main/java/io/airbyte/integrations/standardtest/destination/DestinationAcceptanceTest.java
Line 950 in 09154f3
Let's look into why it wasn't failing prior to #17054, and fix that. (A likely avenue of investigation: should this
sourcenamespace
be randomized per test run?)In order to run
BigQueryGcsDestinationAcceptanceTest
locally, you'll need to manually createairbyte-integrations/connectors/destination-bigquery/secrets/credentials.json
, using the contents here.And you can explore our integration test BigQuery instance here.
The text was updated successfully, but these errors were encountered: