Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Postgres: Disable ssl_mode allow and prefer in CDC mode #17253

Closed
edgao opened this issue Sep 27, 2022 · 1 comment
Closed

Source Postgres: Disable ssl_mode allow and prefer in CDC mode #17253

edgao opened this issue Sep 27, 2022 · 1 comment
Assignees
Labels
connectors/source/postgres needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/bug Something isn't working

Comments

@edgao
Copy link
Contributor

edgao commented Sep 27, 2022

from https://github.com/airbytehq/oncall/issues/687

2022-09-27 12:27:45 source > The 'database.sslmode' value 'allow' is invalid: Value must be one of disable, verify-ca, require, verify-full

At a minimum, we should error during check. Ideally, we'd show those values conditionally (requires https://github.com/airbytehq/airbyte-internal-issues/issues/813).

Unhappy medium would be to move ssl_mode into the replication_method oneof, but that involves a pretty messy upgrade path.

@grishick grishick added the team/db-dw-sources Backlog for Database and Data Warehouse Sources team label Sep 27, 2022
@bleonard
Copy link
Contributor

check command can make sure (if CDC is chosen), the ssl modes fit with the debezium docs
https://debezium.io/documentation/reference/stable/connectors/postgresql.html#postgresql-property-database-sslmode

Triple check for cloud that we enforce ssl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
connectors/source/postgres needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants