Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report affected connectors CI fails if no change applies to connector. #18113

Closed
marcosmarxm opened this issue Oct 18, 2022 · 2 comments · Fixed by #18269
Closed

Report affected connectors CI fails if no change applies to connector. #18113

marcosmarxm opened this issue Oct 18, 2022 · 2 comments · Fixed by #18269
Labels
from/connector-ops type/bug Something isn't working

Comments

@marcosmarxm
Copy link
Member

Example: Report affected connectors

If a PR is submitted with no changes to connector there is a Github Action it will fail. It is not a good experience to contributors and reviewers.
@marcosmarxm marcosmarxm added type/bug Something isn't working from/connector-ops labels Oct 18, 2022
@evantahler
Copy link
Contributor

evantahler commented Oct 18, 2022 •
edited
Loading 

remotes/origin/master...origin/patch-1 -- airbyte-integrations/

these origins and patches could be in the fork, not the main repo

@pedroslopez
Copy link
Contributor

Note:

If a PR is submitted with no changes to connector

From the example in the main post and #18075, it seems like it's due to the PR coming from a fork, rather than because of there being no changes

@pedroslopez pedroslopez mentioned this issue Oct 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
from/connector-ops type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix issues running connector dependency report on PRs from forks airbytehq/airbyte
3 participants
@evantahler @pedroslopez @marcosmarxm