Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connector dependency action report improvements #18139

Closed
pedroslopez opened this issue Oct 18, 2022 · 2 comments · Fixed by #18480
Closed

Connector dependency action report improvements #18139

pedroslopez opened this issue Oct 18, 2022 · 2 comments · Fixed by #18480
Assignees

Comments

@pedroslopez
Copy link
Contributor

pedroslopez commented Oct 18, 2022

We have this action which reports the affected connectors a given PR is touching. It's useful to know whether your changes unexpectedly affect other parts of the codebase, however, it's often spammy and not easy to parse when there are many connectors affected.

We should:

  • Stop commenting on every commit. Instead, we can either comment once and update the same comment or make a new comment if the content has changed.
  • Rather than having a single list of affected connectors, we could split it up with collapsible segments for sources and destinations.

Example:

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

Sources (3)
  • source-cockroachdb
  • source-clickhouse
  • source-snowflake
Destinations (5)
  • source-oracle
  • destination-clickhouse-strict-encrypt
  • destination-local-json
  • destination-mssql-strict-encrypt
  • destination-mssql
@pedroslopez pedroslopez changed the title Connector dependency comment improvements Connector dependency report improvements Oct 18, 2022
@evantahler
Copy link
Contributor

Let's use this issue instead of #18019

@evantahler evantahler changed the title Connector dependency report improvements Connector dependency action report improvements Oct 20, 2022
@pedroslopez pedroslopez self-assigned this Oct 20, 2022
@erohmensing
Copy link
Contributor

closed in #18480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants