Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove supportsDbt and supportsNormalization from DestinationDefinitionSpecificationRead #18239

Closed
andriikorotkov opened this issue Oct 20, 2022 · 1 comment · Fixed by #21005
Closed

Remove supportsDbt and supportsNormalization from DestinationDefinitionSpecificationRead #18239

andriikorotkov opened this issue Oct 20, 2022 · 1 comment · Fixed by #21005
Assignees
@alafanechere @andriikorotkov
Labels
from/connector-ops

Comments

@andriikorotkov
Copy link
Contributor

No description provided.

@tuliren tuliren mentioned this issue Nov 4, 2022
Closed
6 tasks
@evantahler evantahler mentioned this issue Dec 6, 2022
Closed
6 tasks
@pedroslopez pedroslopez mentioned this issue Dec 19, 2022
Merged
@evantahler evantahler mentioned this issue Jan 3, 2023
Closed
37 tasks
@alafanechere alafanechere mentioned this issue Jan 4, 2023
Merged
@alafanechere
Copy link
Contributor

@airbytehq/connector-operations the front-end needs to access the supportsDbt field for the ConnectionTransformationTab. It's currently reading this information from the DestinationDefinitionSpecificationRead model. This story should evolve to be:

  • Remove supportsDbt + supportNormalization from DestinationDefinitionSpecificationRead model
  • Expose supportsDbt + normalization in DestinationDefinitionRead model so that FE can read these field from the API
  • Change DestinationDefinitionsHandler to build DestinationDefinitionRead with these new fields
  • Change the logic in ConnectionTransformationTab to use the definition model and not the spec model.

@evantahler evantahler mentioned this issue Jan 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alafanechere alafanechere

@andriikorotkov andriikorotkov

Labels
from/connector-ops
Projects
None yet
Milestone
No milestone
2 participants
@alafanechere @andriikorotkov