Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google search console] invalid dimensions in custom report should be identified during check instead of discover #18528

Closed
brianjlai opened this issue Oct 27, 2022 · 1 comment
Assignees
Labels

Comments

@brianjlai
Copy link
Contributor

brianjlai commented Oct 27, 2022

Current Behavior

When a customer specifies an invalid dimension in their custom report, it will currently fail during the discover with an invalid key in the map as per: https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-google-search-console/source_google_search_console/streams.py#L329-L342

Expected Behavior

Since the custom report is defined as a config option on the connector, we can verify the validity of their custom report dimensions during the check instead of during discover. This could be done by invoking the self.get_json_schema() for the SearchAnalyticsByCustomDimensions stream as part of the check_connection() method whenever a custom report is defined as a config option.

@grubberr
Copy link
Contributor

grubberr commented Oct 28, 2022

I have improved custom_reports.dimension validation in this PR #18568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants