Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for edit password field in connector: #19233

Closed
edmundito opened this issue Nov 9, 2022 · 3 comments · Fixed by #20723
Closed

Updates for edit password field in connector: #19233

edmundito opened this issue Nov 9, 2022 · 3 comments · Fixed by #20723
Assignees
Labels
area/frontend Related to the Airbyte webapp autoteam

Comments

@edmundito
Copy link
Contributor

edmundito commented Nov 9, 2022

Requested by @Upmitt

  • Cancel button should be on the left side
  • There should be a gap between buttons
  • Edit button should be outline
  • Edit button height should match text input height

Current:

Screen Shot 2022-11-09 at 11.47.21.png

Screen Shot 2022-11-09 at 11.47.28.png

@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@natalyjazzviolin natalyjazzviolin self-assigned this Nov 21, 2022
@natalyjazzviolin
Copy link
Contributor

@edmundito , Sherif assigned this one to me as part of the low-code framework effort.
I have a few questions before I dive in, could you clarify these? I used an API key field as an example as it looks like it has the same functionality as a password field.

Cancel/Done buttons:

Does this look like the correct approach?

Screen Shot 2022-11-21 at 9 59 53 AM

Edit button:

  1. We don't have a primary outline style for the button component. Would the secondary be appropriate here?
  2. The button component does not have a height prop. Would it be better to adjust the height for all buttons so they are uniform? Would it be cleaner to implement a prop? ( I was estimating height in devtools, so apologies that it's slightly off!)

Screen Shot 2022-11-21 at 9 57 29 AM

@edmundito
Copy link
Contributor Author

@natalyjazzviolin I was unaware that the API key and Password field had different edit modes. both should look the same, and API has the correct approach. From the screenshot above, there should be a gap between the input and the cancel button.

For the Edit button:

  1. The secondary is what we want, just like the API key
  2. Height: Let's review this with Nico to confirm what is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp autoteam
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants