Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellation should not be red #19630

Closed
cgardens opened this issue Nov 19, 2022 · 5 comments · Fixed by #20774 or #20999
Closed

Cancellation should not be red #19630

cgardens opened this issue Nov 19, 2022 · 5 comments · Fixed by #20774 or #20999
Assignees

Comments

@cgardens
Copy link
Contributor

Tell us about the problem you're trying to solve

Screen Shot 2022-11-18 at 4 18 12 PM

  • When an attempt is cancelled, the UI shows a red X and a failure reason. This implies that the sync is broken in some way. This is misleading.

Describe the solution you’d like

  • When an attempt is cancelled the symbol should be gray with a more neutral symbol (perhaps a dash), and we should not show the failure reason line. There should be no red.

@timroes is the workflows team the right place to send this?

@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@timroes
Copy link
Contributor

timroes commented Nov 19, 2022

@timroes is the workflows team the right place to send this?

👍 Yes it is!

@edmundito
Copy link
Contributor

cc @Upmitt

@andyjih
Copy link
Contributor

andyjih commented Nov 29, 2022

Ideas here:

  • "Failure Origin" makes it read like a failure. How does this message get populated? Is there a way for us to change the wording so it doesn't show "Failure Origin"?
  • Separately, if we can use a different color or icon instead of a red X. Maybe we can borrow from Github Action's pattern of a minus or slash with a circle around it:

Image

@edmundito
Copy link
Contributor

I will take another pass at removing some of the text mentioned here:
#20774 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants