Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector form: Apply validation in array item modal form #20234

Closed
flash1293 opened this issue Dec 8, 2022 · 2 comments · Fixed by #20725
Closed

Connector form: Apply validation in array item modal form #20234

flash1293 opened this issue Dec 8, 2022 · 2 comments · Fixed by #20725
Assignees
@flash1293
Labels
area/frontend Related to the Airbyte webapp team/extensibility type/enhancement New feature or request

Comments

@flash1293
Copy link
Contributor

Currently validation messages are not visible in the modal when editing an item from an object array.

This ticket is about handling validation in there in the same way validation is handled in the main form.

Following changes are necessary:

  • Do not copy the item to edit into a special temp key, instead edit the main item directly
  • To not see flickering changes in the background of the modal keep a local state in the array section component (can also be used to revert when the user hits cancel)
@flash1293 flash1293 added type/enhancement New feature or request team/extensibility area/frontend Related to the Airbyte webapp labels Dec 8, 2022
@octavia-squidington-iv
Copy link

cc @airbytehq/frontend

@flash1293 flash1293 self-assigned this Dec 20, 2022
@flash1293 flash1293 mentioned this issue Dec 20, 2022
Merged
@flash1293
Copy link
Contributor Author

Done, waiting for code freeze to be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
area/frontend Related to the Airbyte webapp team/extensibility type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪟🎉 Connector form: Use proper validation in array section airbytehq/airbyte
2 participants
@flash1293 @octavia-squidington-iv