Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable deselection of cursor field/primary key #20586

Closed
josephkmh opened this issue Dec 16, 2022 · 1 comment · Fixed by #20844
Closed

Disable deselection of cursor field/primary key #20586

josephkmh opened this issue Dec 16, 2022 · 1 comment · Fixed by #20844
Assignees
@josephkmh
Labels
area/frontend Related to the Airbyte webapp team/compose

Comments

@josephkmh
Copy link
Contributor

josephkmh commented Dec 16, 2022 •
edited
Loading

  1. The toggle for a primary key should be disabled, with a tooltip reading The primary key cannot be deselected
  2. The toggle for a cursor field should be disabled, with a tooltip reading The cursor field cannot be deselected
  3. If a user changes the primary key or cursor field, that field is automatically selected (if it was deselected before) and then disabled
@josephkmh josephkmh self-assigned this Dec 16, 2022
@pmossman
Copy link
Contributor

Refining notes:

  • Making sure we all agree on the steps above, sounds like we do so we're good to go ahead with this

@josephkmh josephkmh mentioned this issue Dec 22, 2022
Merged
@timroes timroes added area/frontend Related to the Airbyte webapp and removed area/frontend labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephkmh josephkmh

Labels
area/frontend Related to the Airbyte webapp team/compose
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪟 🎉 Disable deselection of cursor field/primary key in the UI airbytehq/airbyte
3 participants
@timroes @josephkmh @pmossman