Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove calls to "list_by_workspace" and "list_latest" from Sources and Destination list pages #20667

Closed
krishnaglick opened this issue Dec 19, 2022 · 2 comments
Closed

Remove calls to "list_by_workspace" and "list_latest" from Sources and Destination list pages #20667

krishnaglick opened this issue Dec 19, 2022 · 2 comments
Assignees
@krishnaglick
Labels
priority/medium Medium priority team/platform-move

Comments

@krishnaglick
Copy link
Contributor

getEntityTableData currently makes calls to list_by_workspace and list_latest solely to get the connector icon. The connector icon is available on the source or destination object directly so the calls should be removed and the icon retrieved from the source or destination object.
@krishnaglick krishnaglick self-assigned this Dec 19, 2022
@krishnaglick krishnaglick mentioned this issue Dec 19, 2022
Merged
@dizel852
Copy link
Contributor

Need to create separate FE issue

@krishnaglick
Copy link
Contributor Author

This should be the frontend issue? It's a small change iirc.

@krishnaglick krishnaglick mentioned this issue Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krishnaglick krishnaglick

Labels
priority/medium Medium priority team/platform-move
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove definitions from getEntityTableData method airbytehq/airbyte
2 participants
@krishnaglick @dizel852