You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
. Because we read the content of any Text node and set it's innerHtml via dangerouslySetInnerHtml to the tooltip after decodeUriComponents, you can inject code into the DOM, if e.g. a field is named %3Cimg onerror='alert("should not happen")' src="reallynotgood" /%3E, which will execute JS once a user hovers over the field.
We luckily don't have the new table design roled out to any user yet, thus this is not critical enough to need to be reverted, but this should be fixed asap still.
The correct implementation here would be to simply clone the original text node and attach it to the tooltip.
The text was updated successfully, but these errors were encountered:
Currently #21253 introduced a XSS vulnerability that allows injecting bad code into the streams table in
airbyte/airbyte-webapp/src/components/connection/CatalogTree/next/CatalogTreeTableCell.tsx
Line 30 in 09421ce
Text
node and set it'sinnerHtml
viadangerouslySetInnerHtml
to the tooltip after decodeUriComponents, you can inject code into the DOM, if e.g. a field is named%3Cimg onerror='alert("should not happen")' src="reallynotgood" /%3E
, which will execute JS once a user hovers over the field.We luckily don't have the new table design roled out to any user yet, thus this is not critical enough to need to be reverted, but this should be fixed asap still.
The correct implementation here would be to simply clone the original text node and attach it to the tooltip.
The text was updated successfully, but these errors were encountered: