Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phase 1 of DB sources refactoring #23808

Closed
akashkulk opened this issue Mar 7, 2023 · 2 comments
Closed

Phase 1 of DB sources refactoring #23808

akashkulk opened this issue Mar 7, 2023 · 2 comments
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request

Comments

@akashkulk
Copy link
Contributor

akashkulk commented Mar 7, 2023 •
edited
Loading

Can find the tech spec here : https://docs.google.com/document/d/15xFQ0EX9K_IfX_bPt-wCfhYYwkVqW2IvvbTvWKgyYRg/edit#heading=h.eds8ikoyuyn1

Some cleanup ideas

  • Move methods into utility classes
  • Figure out which methods are only used in a couple of sub-classes and pull them up to their subclasses
  • Some code may be duplicated in AbstractJdbcSource and AbstractDbSource since the former would no longer inheirit from the former
@akashkulk akashkulk added type/enhancement New feature or request needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team labels Mar 7, 2023
@prateekmukhedkar
Copy link
Contributor

prateekmukhedkar commented Mar 8, 2023 •
edited
Loading

Refactoring change. Impact: Reduce blast radius when making a change.
Existing unit tests may not be impacted.

This was referenced Mar 14, 2023
Merged
Closed
@akashkulk akashkulk added the Epic label Mar 23, 2023
@akashkulk akashkulk changed the title Break up AbstractJdbcSource -> AbstractDbSource inheiratance chain Phase 1 of DB sources refactoring Mar 23, 2023
@akashkulk
Copy link
Contributor Author

closing in favor of epic : https://github.com/airbytehq/airbyte-internal-issues/issues/1555

@akashkulk akashkulk removed the Epic label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@akashkulk @prateekmukhedkar