Source Bing Ads: add missing dimensional columns in reports

[rach-r]

Environment

• Source Connector and version: Bing Ads 0.1.18 (latest as of today)
• Step where error happened: After sync job (which is successful), when data modelling for report

Current Behavior

Today there are two types of streams:

• dimensional-like ones (like campaigns, accounts, ad_groups...)
• fact-like ones (reports like campaign_performance_report_daily, account_performance_report_daily, ad_group_performance_report_daily,...)

To create a reporting, you would usually JOIN fact tables with dimensional one to have metrics split by dimensional columns (ex: conversion by CampaignType, CampaignName...).

However, dimensional tables do not contain data for DELETED items; so when in a report you're trying to get past data about a DELETED campaign (or ad_group or ad...) then you can't retrieve basic information like the Name or the Type of the item. The JOIN returns a NULL for deleted items and it defeats most analysis that you would do on this kind of data, like YoY performance by CampaignType for instance.

Expected Behavior

You should be able to retrieve basic dimensional columns for reports, including for DELETED items.

Additional Information

As it's not possible to retrieve DELETED items from dimensional tables and Bing Ads offer the possibility to add some dimensional columns to reports tables (like mentioned here for CampaignReport but also available for AccountReport, AdReport...), then add them.

Steps to Reproduce

1. Create a campaign, run it for some days, then delete it
2. Sync campaigns and campaign_performance_report_daily
3. When looking at this specific campaign, you only find its CampaignId in campaign_performance_report_daily so you join with campaigns to get basic info like CampaignName
4. When joining, you get NULL, and when looking for this CampaignId in campaigns it does not exist. It's because dimensional stream campaigns can't retrieve DELETED items

Are you willing to submit a PR?

Yes, joining link very soon!