Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectors-ci: maximize concurrency and document high level DAG #23966

Closed
alafanechere opened this issue Mar 13, 2023 · 0 comments · Fixed by #23967
Closed

connectors-ci: maximize concurrency and document high level DAG #23966

alafanechere opened this issue Mar 13, 2023 · 0 comments · Fixed by #23967
Assignees
Labels

Comments

@alafanechere
Copy link
Contributor

alafanechere commented Mar 13, 2023

Tell us about the problem you're trying to solve

While implementing the POC we left aside a couple of optimizations related to testing execution concurrency.
We should ensure all the steps not depending on each other can run in parallel and are not blocking each other.

Describe the solution you’d like

Basically follow Dagger's team suggestion:
Discard calls made to asyncio and rely only on anyio / asyncer to benefit from the structured concurrency paradigm which makes understanding concurrent code easier.

We should target the following DAG for each connector pipeline on running connectors-ci test-connectors:

flowchart TB
    conn([Connector pipeline])==>qa & fmt & tu
    src[[Mount connector source code to container]]-->fmt & pkg & ta
    fmt & tu & ti & ta & qa -.-> r([Build test report])--if in CI-->s3[[Upload to S3]]
    subgraph QA Checks
        repo[[Mount Airbyte repo to container]]-->qa[Run QA checks]
    end
    subgraph Tests
        tu[Run unit tests]==>ti[Run integration tests] & ta[Run acceptance tests]
        pkg[[Install connector package in container]]-->tu & ti
        dsec[[Download secrets from GSM]] --> ti & ta
        subgraph Acceptance
            bld[[Build connector dev image]]-->ta-->upsec[[Upload updated secrets to GSM]]
        end
    end
    subgraph Code format
        fmt[Run code format checks]
    end
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants