Source Amplitude: Add undeclared columns to spec #24480
Labels
area/connectors
Connector related issues
column-selection-sources
team/connectors-python
type/enhancement
New feature or request
What
In this PR,
BasicReadTest.test_read
test in the Connector Acceptance Tests was updated to fail if the connector producesstream records which contain columns that haven't been declared in the spec.
Amplitude currently fails the updated test. Its
acceptance-test-config.yml
was edited with thefail_on_extra_columns: false
parameter in order to avoid this change from making the connector fail CAT.We want to add the undeclared columns to the spec.
How this will help:
is because turning on column selection will stop these undeclared columns from being sent, when they were
previously being sent. Doing this allows us to enable column selection for Amplitude!
How
The following descriptions of streams that pass undeclared columns come from results of the failed connector acceptance test:
Additional properties are not allowed ('<column>', 'column' were unexpected)
logs to the connector's spec.fail_on_extra_columns: false
from theacceptance-test-config.yml
file.acceptance-test-config.yml
and open a PR./test
commandDefinition of done: Amplitude passes CAT without declaring
fail_on_extra_columns: false
. If theAPI starts sending over extra columns in the future, we will catch and fix them as part of the #connector-health
movement.
The text was updated successfully, but these errors were encountered: