Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Check that the docker version in the metadata file has changed if any other files have changed in the connector folder #25329

Closed
bnchrch opened this issue Apr 19, 2023 · 0 comments · Fixed by #25609

Comments

@bnchrch
Copy link
Contributor

bnchrch commented Apr 19, 2023

Overview

If any file has changed in a connector folder, ensure that the version has changed.

Solution

  1. parse the local metadata.yml file
  2. parse the remote metadata.yml file (github raw)
  3. check if the dockerImageTag version is semver and has increased, (ignore in the prerelase version case 1.2.3-dev.asd213
  4. if it has increased, pass, if not, fail

Extra considerations

Lets use this as a way to gate expensive tests.

So this check should be run early in the CI pipeline, if it fails then skip remaining tests.

@bnchrch bnchrch changed the title CI: Check that the docker version in the metadata file if any other files have changed in the connector folder CI: Check that the docker version in the metadata file has changed if any other files have changed in the connector folder Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant