Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-postgres: improve test setup and teardown to make them faster #31438

Closed
alafanechere opened this issue Oct 16, 2023 · 5 comments
Closed
Assignees

Comments

@alafanechere
Copy link
Contributor

Java tests (unit / integration) rely on services like Debezium and testcontainers. A lot of runtime is spent waiting for these services to be available. E.G: in unit tests wait 1mn for debezium to start. For testcontainers: a lot of database containers are started (one by test): it’s resource intensive and might be optimizable with clever container reuse.

Furthermore, in Java tests, a lot of tests are effectively skipped by early exits, because those tests are defined in connector-agnostic base classes. However, we still pay the price of doing setups and teardowns.

Finally, on CAT very simple tests like spec take a couple of minutes to run. This can be due to a CAT daggerization overhead

@alafanechere
Copy link
Contributor Author

alafanechere commented Oct 24, 2023

Finally, on CAT very simple tests like spec take a couple of minutes to run. This can be due to a CAT daggerization overhead

This is addressed in #31699 and had a specific issue #31703

@postamar
Copy link
Contributor

See #31298 for profiling results.

@postamar
Copy link
Contributor

#31818 covers the testcontainers aspect of this issue and is the only outstanding thing remaining here.

@bnchrch
Copy link
Contributor

bnchrch commented Nov 15, 2023

@postamar Just wanted to checkin if this is able to be considered done and closed?

@postamar
Copy link
Contributor

Oh yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants