Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java CDK: use slf4j v2.x #31817

Closed
postamar opened this issue Oct 25, 2023 · 0 comments · Fixed by #32050
Closed

java CDK: use slf4j v2.x #31817

postamar opened this issue Oct 25, 2023 · 0 comments · Fixed by #32050
Assignees
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team

Comments

@postamar
Copy link
Contributor

Topic

No response

Relevant information

The performance investigation of the tests in source-postgres revealed that java connector containers could require the better part of a second to do something as basic as respond to a spec API call. See #31298 (comment)

Part of what causes the latency to be high is setting up the log machinery. SLF4J version 1.7.x, which is what we currently use, performs an expensive method call that version 2.x skips.

The method in question is findPossibleStaticLoggerBinderPathSet in LoggerFactory and essentially looks up a class in all of the jars on the classpath. Of course part of the problem is that we have a lot of jars ( see #31400 ) but this call is wasteful. It accounts for about 100ms on my laptop.

If all we have to do is bump a few dependencies and tweak a few settings then we should do it.

@postamar postamar added needs-triage team/db-dw-sources Backlog for Database and Data Warehouse Sources team and removed needs-triage labels Oct 25, 2023
@postamar postamar self-assigned this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/db-dw-sources Backlog for Database and Data Warehouse Sources team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant