You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current implementation naively assumes that all authentication works through request headers, unfortunately, that is not the case, API keys can be sent via:
query params
cookies
body post
Describe the solution you’d like
The authenticator should support only one method:
defauthenticate(self, session: Session):
pass
Describe the alternative you’ve considered or used
Set Authenticator to NoAuth and implement authentication in request_params method.
Additional context
Add any other context or screenshots about the feature request here.
May be linked to #5246
During the research I've discovered that the best way to implement base universal authenticator class is to use it as auth argument to requests.Request class.
Create the child classes, which are going to implement some of our main authentication methods (currently NoAuth, Oauth2Authenticator, TokenAuthenticator)
Update the rest of the codebase to support newly created authenticators (I think it should be done in the follow up issue, and before that it's better to keep both versions of the authenticator classes).
Tell us about the problem you're trying to solve
The current implementation naively assumes that all authentication works through request headers, unfortunately, that is not the case, API keys can be sent via:
Describe the solution you’d like
The authenticator should support only one method:
Describe the alternative you’ve considered or used
Set Authenticator to
NoAuth
and implement authentication inrequest_params
method.Additional context
Add any other context or screenshots about the feature request here.
Are you willing to submit a PR?
Your answer
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: