Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDK: Schema resolver should support nested references #4128

Closed
keu opened this issue Jun 15, 2021 · 0 comments · Fixed by #6044
Closed

CDK: Schema resolver should support nested references #4128

keu opened this issue Jun 15, 2021 · 0 comments · Fixed by #6044
Assignees
Labels
CDK Connector Development Kit type/enhancement New feature or request

Comments

@keu
Copy link
Contributor

keu commented Jun 15, 2021

Tell us about the problem you're trying to solve

The discovery command should produce resolvable schemas, i.e. without referencing any external files.
Currently we use simple algorithm as a workaround:

  1. move external files to shared folder
  2. during discovery we load schemas and replace any reference to shared files with the content of these files

This of course has doesn't cover all cases:

  1. reference inside shared files
  2. reference to definitions sections

Describe the solution you’d like

We should process all $refs recursively and generate the definitions section as Pydantic does. Ideally, we would like to use Pydantic where it is possible

Describe the alternative you’ve considered or used

none

Additional context

Example of such schemas in the FB connector:

Are you willing to submit a PR?

Your answer

@keu keu added type/enhancement New feature or request CDK Connector Development Kit labels Jun 15, 2021
@htrueman htrueman assigned htrueman and unassigned htrueman Sep 8, 2021
@avida avida self-assigned this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDK Connector Development Kit type/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants