You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The discovery command should produce resolvable schemas, i.e. without referencing any external files.
Currently we use simple algorithm as a workaround:
move external files to shared folder
during discovery we load schemas and replace any reference to shared files with the content of these files
This of course has doesn't cover all cases:
reference inside shared files
reference to definitions sections
Describe the solution you’d like
We should process all $refs recursively and generate the definitions section as Pydantic does. Ideally, we would like to use Pydantic where it is possible
Describe the alternative you’ve considered or used
Tell us about the problem you're trying to solve
The
discovery
command should produce resolvable schemas, i.e. without referencing any external files.Currently we use simple algorithm as a workaround:
shared
folderThis of course has doesn't cover all cases:
Describe the solution you’d like
We should process all
$ref
s recursively and generate thedefinitions
section as Pydantic does. Ideally, we would like to use Pydantic where it is possibleDescribe the alternative you’ve considered or used
none
Additional context
Example of such schemas in the FB connector:
airbyte/airbyte-integrations/connectors/source-facebook-marketing/source_facebook_marketing/schemas/shared/targeting.json
Line 21 in 9e260fe
Are you willing to submit a PR?
Your answer
The text was updated successfully, but these errors were encountered: