-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove worker dependency from normalization module version #5349
Comments
I think what we've discussed before is having the normalization version be in sync with the overall Airbyte version. It's very hard to guarantee a range of versions compatible with a normalization version, so it's effectively tied to the same version anyway at the moment (which is why it isn't configurable). |
related: #2054 |
Even if normalization is tied to an airbyte version, it could sometimes be helpful to have the ability to hot-swap/plug another normalization image But this should probably be an exception rather than the general usage |
Closing this in favor of #16671 which will strongly decouple normalization from the workers |
Tell us about the problem you're trying to solve
airbyte/airbyte-workers/src/main/java/io/airbyte/workers/normalization/DefaultNormalizationRunner.java
Line 50 in 12ed325
This can lead to a problem when we upgrade normalization. We need to wait for a new Airbyte release to be able to use. Or, if we introduce a bug in normalization people can't downgrade to a older version and keep using Airbyte.
Describe the solution you’d like
Probably we could add a env variable to be more flexible choosing the normalization operation version.
Describe the alternative you’ve considered or used
None
Additional context
Add any other context or screenshots about the feature request here.
Are you willing to submit a PR?
Yes
The text was updated successfully, but these errors were encountered: