Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redshift destination : remove extra serialization #5741

Closed
DoNotPanicUA opened this issue Aug 30, 2021 · 2 comments
Closed

Redshift destination : remove extra serialization #5741

DoNotPanicUA opened this issue Aug 30, 2021 · 2 comments
Assignees
@andriikorotkov
Labels
area/connectors Connector related issues connectors/destination/redshift connectors/destinations-warehouse lang/java

Comments

@DoNotPanicUA
Copy link
Contributor

This is a problem, we are not going to do Jsons.serialize twice for Redshift. First in the isValidData method and then here

Originally posted by @subodh1810 in #5336 (comment)
@sherifnada sherifnada added area/connectors Connector related issues lang/java labels Aug 31, 2021
@haoranyu
Copy link
Contributor

haoranyu commented Dec 5, 2021

It seems to be only one Jsons.serialize call in isValidData now. Is this issue still valid?

@sherifnada sherifnada moved this to Backlog in GL Roadmap Jan 12, 2022
@igrankova igrankova moved this from Backlog to Backlog (unscoped) in GL Roadmap Feb 2, 2022
@alexandr-shegeda alexandr-shegeda moved this from Backlog (unscoped) to Ready for implementation (prioritized) in GL Roadmap Feb 14, 2022
@andriikorotkov andriikorotkov self-assigned this Mar 8, 2022
@andriikorotkov andriikorotkov moved this from Ready for implementation (prioritized) to Implementation in progress in GL Roadmap Mar 8, 2022
@andriikorotkov
Copy link
Contributor

This task is no longer relevant. These changes were added on 15.09.21 - in this pull request - #5998

@andriikorotkov andriikorotkov moved this from Implementation in progress to Done in GL Roadmap Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andriikorotkov andriikorotkov

Labels
area/connectors Connector related issues connectors/destination/redshift connectors/destinations-warehouse lang/java
Projects
No open projects
GL Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@haoranyu @sherifnada @DoNotPanicUA @igrankova @andriikorotkov