Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK: remove legacy authenticator references #5755

Closed
Tracked by #19239
htrueman opened this issue Aug 31, 2021 · 0 comments
Closed
Tracked by #19239

CDK: remove legacy authenticator references #5755

htrueman opened this issue Aug 31, 2021 · 0 comments
Labels
area/connectors Connector related issues autoteam CDK Connector Development Kit CDKv2 frozen Not being actively worked on team/connectors-python team/extensibility type/enhancement New feature or request

Comments

@htrueman
Copy link
Contributor

Tell us about the problem you're trying to solve

There are new requests native authenticators implemented #5731. For now we support both requests native and HttpAuthenticator authenticators. Need to remove in the whole project HttpAuthenticator.

Describe the solution you’d like

  • Remove airbyte_cdk.sources.streams.http.auth module.
  • Rename airbyte_cdk.sources.streams.http.requests_native_auth to airbyte_cdk.sources.streams.http.auth.
  • Update airbyte_cdk.sources.streams.http.auth overrides thought the project where it's needed.

Are you willing to submit a PR?

I might take it, right after #5731 is merged.
@htrueman htrueman added the type/enhancement New feature or request label Aug 31, 2021
@htrueman htrueman mentioned this issue Aug 31, 2021
Merged
36 tasks
@sherifnada sherifnada added area/connectors Connector related issues CDK Connector Development Kit CDKv2 labels Sep 3, 2021
@sherifnada sherifnada mentioned this issue Nov 9, 2022
Closed
10 tasks
@bleonard bleonard added the frozen Not being actively worked on label Mar 22, 2024
@girarda girarda closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connectors Connector related issues autoteam CDK Connector Development Kit CDKv2 frozen Not being actively worked on team/connectors-python team/extensibility type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bleonard @girarda @sherifnada @htrueman @octavia-squidington-iii