-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Smartsheets: support oauth #6280
Comments
LastPass cred name: Smartsheet developer app |
@midavadim is this actually in progress? moving to backlog, please let me know if you're actually working on it |
@igrankova @sherifnada does the fact that the access token expires in 7 days mean that a user would have to re-authenticate every 7 days if they use OAuth? Did this also remove the option for Cloud users to use just the API key to Authenticate? |
I think this will require single-use-refresh-tokens cc @YowanR |
Can I get clarification on my first question. Will any user that sets up their Smartsheets Connection via OAuth have to re-authenticate every 7 days? |
This could be a problem because currently the "re-authenticate" button is broken (Issue) for existing connections so the user would have to make a new connector every 7 days. |
Tell us about the problem you're trying to solve
With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.
If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. I suggest that this be a oneof nested inside a top-level field called "authentication":
{ authentication: { type: object oneOf: [ // api key, // oauth ] } }
See the connector spec reference in the docs for reference on how a oneof can be implemented.
This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: