Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Smartsheets: support oauth #6280

Closed
Tracked by #7000
sherifnada opened this issue Sep 19, 2021 · 6 comments · Fixed by #9792
Closed
Tracked by #7000

Source Smartsheets: support oauth #6280

sherifnada opened this issue Sep 19, 2021 · 6 comments · Fixed by #9792

Comments

@sherifnada
Copy link
Contributor

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret
  2. Oauth properties are annotated properly. See this PR for an example
@sherifnada sherifnada added area/oauth area/connectors Connector related issues labels Sep 19, 2021
@igrankova igrankova self-assigned this Oct 18, 2021
@igrankova
Copy link
Contributor

LastPass cred name: Smartsheet developer app
OAuth flow passed, App is public (App name: Airbyte).
Code expires in 10 min
Access Token expires in 7 days

@sherifnada
Copy link
Contributor Author

@midavadim is this actually in progress? moving to backlog, please let me know if you're actually working on it

@midavadim midavadim self-assigned this Dec 10, 2021
@sherifnada sherifnada moved this to Backlog in GL Roadmap Jan 12, 2022
@midavadim midavadim moved this from Backlog to Implementation in progress in GL Roadmap Jan 18, 2022
@midavadim midavadim linked a pull request Jan 25, 2022 that will close this issue
40 tasks
@midavadim midavadim moved this from Implementation in progress to Internal review in GL Roadmap Jan 25, 2022
@igrankova igrankova moved this to Backlog (unscoped) in GL Roadmap Feb 2, 2022
@midavadim midavadim moved this from Backlog (unscoped) to In review (internal) in GL Roadmap Feb 3, 2022
@midavadim midavadim moved this from In review (internal) to In review (Airbyte) in GL Roadmap Feb 3, 2022
@midavadim midavadim moved this from In review (Airbyte) to Done in GL Roadmap Feb 4, 2022
@tybernstein
Copy link
Contributor

@igrankova @sherifnada does the fact that the access token expires in 7 days mean that a user would have to re-authenticate every 7 days if they use OAuth? Did this also remove the option for Cloud users to use just the API key to Authenticate?

@sherifnada
Copy link
Contributor Author

I think this will require single-use-refresh-tokens cc @YowanR

@tybernstein
Copy link
Contributor

Can I get clarification on my first question. Will any user that sets up their Smartsheets Connection via OAuth have to re-authenticate every 7 days?

@tybernstein
Copy link
Contributor

This could be a problem because currently the "re-authenticate" button is broken (Issue) for existing connections so the user would have to make a new connector every 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants