Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Zendesk Support: support oauth #6285

Closed
Tracked by #7341 ...
sherifnada opened this issue Sep 19, 2021 · 3 comments · Fixed by #11162
Closed
Tracked by #7341 ...

Source Zendesk Support: support oauth #6285

sherifnada opened this issue Sep 19, 2021 · 3 comments · Fixed by #11162

Comments

@sherifnada
Copy link
Contributor

sherifnada commented Sep 19, 2021

Tell us about the problem you're trying to solve

With the release of Airbyte Cloud, we need to start supporting Oauth for this connector, since it's the recommended way of authenticating users into a SaaS application.

If this connector doesn't support oauth already (i.e: doesn't accept a client_id and client_secret) then we need to update its spec to accept those parameters. There are two ways to do this:

If the connector already supports some auth mechanism like api_key, I suggest that this be a oneof nested inside a top-level field called "authentication":

{ authentication: { type: object oneOf: [ // api key, // oauth ] } }

If the connector only supports webflow oauth, then no changes are needed to the properties format and we will only need to add annotations.

See the connector spec reference in the docs for reference on how a oneof can be implemented.

This should be done in a backwards compatible manner i.e: users currently supplying authentication info in the config's top-level should not be impacted by this change.

Acceptance Criteria

  1. The connector supports oauth webflow authentication with client_id/client_secret in a backwards compatible manner
  2. Oauth properties are annotated properly. See this PR for an example
@sherifnada sherifnada added area/oauth area/connectors Connector related issues labels Sep 19, 2021
@sherifnada sherifnada changed the title Source Zendesk: support oauth Source Zendesk Support: support oauth Sep 20, 2021
@cheyura cheyura self-assigned this Sep 25, 2021
@cheyura
Copy link

cheyura commented Sep 25, 2021

@sherifnada Public app created

@antixar antixar assigned antixar and unassigned cheyura Sep 29, 2021
@antixar antixar linked a pull request Oct 15, 2021 that will close this issue
15 tasks
@antixar
Copy link
Contributor

antixar commented Nov 4, 2021

Oauth2 logic of connectors Zendesk Support and Zendesk Talk is same. Their access tokens are fully compatible.
Python part:

Zendesk Talk
Zendesk Support

Zendesk docs
Necessary scopes' value: read
Example of consent url: https://{subdomain}.zendesk.com/oauth/authorizations/new?.....
Example of token url: https://{subdomain}.zendesk.com/oauth/tokens
where subdomain should be forwarded from UI part

The Zendesk oAuth2 implementation returns long-term access_token without refresh_token

@bazarnov
Copy link
Collaborator

#7086

@bazarnov bazarnov moved this from Blocked to Implementation in progress in GL Roadmap Mar 10, 2022
@bazarnov bazarnov assigned bazarnov and unassigned antixar Mar 15, 2022
@bazarnov bazarnov removed a link to a pull request Mar 15, 2022
15 tasks
@bazarnov bazarnov linked a pull request Mar 15, 2022 that will close this issue
12 tasks
@oustynova oustynova moved this from Implementation in progress to Done in GL Roadmap Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants