Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Facebook Marketing: Fix schema fields with $ref displaying in UI #7672

Closed
htrueman opened this issue Nov 5, 2021 · 1 comment
Closed

Source Facebook Marketing: Fix schema fields with $ref displaying in UI #7672

htrueman opened this issue Nov 5, 2021 · 1 comment
Labels
area/connectors Connector related issues connectors/destination/postgres connectors/destinations-database connectors/source/facebook-marketing connectors/sources-api type/bug Something isn't working
Milestone
Connectors 2021-1...

Comments

@htrueman
Copy link
Contributor

htrueman commented Nov 5, 2021

Issue appeared in #7605.

Enviroment

  • Airbyte version: 0.1.32
  • OS Version / Instance: macOS
  • Deployment: Docker
  • Source Connector and version: Facebook Marketing 0.2.21
  • Destination Connector and version: Postgres 0.3.11
  • Severity: Low
  • Step where error happened: Setup new connection

Current Behavior

null field types in fields where we use $ref in field definition instead of array or object types. See screenshot attached.

Screenshot 2021-11-05 at 15 36 19

Expected Behavior

Field types should be displayed correctly.

Steps to Reproduce

  1. Setup new connection with given source and destination.
  2. Check connector settings.

Are you willing to submit a PR?

I think it should submit someone who worked with UI.
@htrueman htrueman added the type/bug Something isn't working label Nov 5, 2021
@htrueman htrueman mentioned this issue Nov 5, 2021
Merged
38 tasks
@sherifnada
Copy link
Contributor

@htrueman should this be closed?

@sherifnada sherifnada added the area/connectors Connector related issues label Nov 15, 2021
@VasylLazebnyk VasylLazebnyk added this to the Connectors 2021-11-12 milestone Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/connectors Connector related issues connectors/destination/postgres connectors/destinations-database connectors/source/facebook-marketing connectors/sources-api type/bug Something isn't working
Projects
None yet
Milestone
Connectors 2021-11-12
Development

No branches or pull requests
5 participants
@sherifnada @karinakuz @htrueman @VasylLazebnyk @igrankova