Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Change JsonSchemaPrimitive to a class #7944

Closed
VitaliiMaltsev opened this issue Nov 13, 2021 · 2 comments · Fixed by #9913
Closed

[EPIC] Change JsonSchemaPrimitive to a class #7944

VitaliiMaltsev opened this issue Nov 13, 2021 · 2 comments · Fixed by #9913
Assignees
Labels
area/connectors Connector related issues area/databases Epic type/enhancement New feature or request

Comments

@VitaliiMaltsev
Copy link
Contributor

Tell us about the problem you're trying to solve

According to conversation in #7859 it's needed to change JsonSchemaPrimitive from enum to class which allows more flexible specifications

@VitaliiMaltsev VitaliiMaltsev added the type/enhancement New feature or request label Nov 13, 2021
@sherifnada sherifnada added the area/connectors Connector related issues label Nov 15, 2021
@alexandr-shegeda alexandr-shegeda changed the title Change JsonSchemaPrimitive to a class [EPIC] Change JsonSchemaPrimitive to a class Nov 18, 2021
@alexandr-shegeda alexandr-shegeda self-assigned this Nov 18, 2021
@oustynova oustynova moved this to Ready for implementation in GL Roadmap Dec 15, 2021
@tuliren
Copy link
Contributor

tuliren commented Dec 20, 2021

  • This issue needs a design doc first. We need to fully understand its impact on the destination side.
  • If the implementation does not break destinations, carry on according to the design doc.
  • If the implementation does break destinations, we need to
    • Update the destinations first (probably in dbt) to be compatible with both the date + time format, as well as the date-only format first.
    • Then make the change on the source side.

@alexandr-shegeda alexandr-shegeda moved this from Ready for implementation to Backlog in GL Roadmap Dec 23, 2021
@alexandr-shegeda alexandr-shegeda moved this from Backlog to Ready for implementation in GL Roadmap Jan 13, 2022
@VitaliiMaltsev
Copy link
Contributor Author

VitaliiMaltsev commented Jan 13, 2022

@tuliren @sherifnada created design doc https://docs.google.com/document/d/1MxVLBuN2xDye0IPKsCsp4L5HLU6JosnWRxp3kEekpgw/edit. Please review

@VitaliiMaltsev VitaliiMaltsev moved this from Ready for implementation to Scoping complete in GL Roadmap Jan 25, 2022
@VitaliiMaltsev VitaliiMaltsev moved this from Scoping complete to Implementation in progress in GL Roadmap Jan 25, 2022
@VitaliiMaltsev VitaliiMaltsev moved this from Implementation in progress to Internal review in GL Roadmap Feb 1, 2022
@VitaliiMaltsev VitaliiMaltsev linked a pull request Feb 1, 2022 that will close this issue
40 tasks
@igrankova igrankova moved this to In review (internal) in GL Roadmap Feb 2, 2022
@alexandr-shegeda alexandr-shegeda moved this from In review (internal) to In review (Airbyte) in GL Roadmap Feb 8, 2022
@alexandr-shegeda alexandr-shegeda moved this from In review (Airbyte) to Done in GL Roadmap Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/databases Epic type/enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants