Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Test for Basic Normalization Module #965

Closed
cgardens opened this issue Nov 12, 2020 · 2 comments
Closed

Integration Test for Basic Normalization Module #965

cgardens opened this issue Nov 12, 2020 · 2 comments
Labels
type/enhancement New feature or request

Comments

@cgardens
Copy link
Contributor

Tell us about the problem you're trying to solve

  • This module should have tests that run against an external database (or maybe we could make them unit tests and run against a locally run postgres docker container). Either way, it needs more holistic tests.

Splitting this out from the main Basic Normalization issue: #782
@cgardens cgardens added the type/enhancement New feature or request label Nov 12, 2020
@cgardens cgardens added this to the v0.6.0 milestone Nov 12, 2020
@cgardens cgardens mentioned this issue Nov 12, 2020
Closed
@ChristopheDuong ChristopheDuong mentioned this issue Nov 13, 2020
Merged
@ChristopheDuong
Copy link
Contributor

ChristopheDuong commented Nov 13, 2020 •
edited
Loading

Regarding #970 (review), we could add a test from (a generated dataset) with more than 100 columns? (maybe from CSV source?)

@cgardens cgardens modified the milestones: v0.6.0, v0.7.0 Nov 23, 2020
@sherifnada
Copy link
Contributor

this is now available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sherifnada @ChristopheDuong @cgardens